Refactor default safety values tip into an includable file #1015
+11
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: ahouseholder <[email protected]>
Copilot
AI
changed the title
Copilot finished work on behalf of
ahouseholder
October 10, 2025 20:48
ahouseholder
requested review from
cgyarbrough,
j--- and
sei-vsarvepalli
as code owners
ahouseholder
requested review from
Copilot
and removed request for
cgyarbrough,
j--- and
sei-vsarvepalli
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the "Default Safety Values" tip from inline content into a reusable includable file, enabling consistent presentation of safety impact guidance across multiple documentation pages.
- Extracted the default safety values tip into a dedicated includable file
- Replaced inline tip content with include statements in affected files
- Added the tip to the Safety Impact reference page and its gathering information section
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| docs/_includes/default_safety_values.md | New includable file containing the default safety values tip with updated relative path |
| docs/howto/bootstrap/collect.md | Replaced inline tip with include statement |
| docs/reference/decision_points/safety_impact.md | Added include statements in two strategic locations for better visibility |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ahouseholder
added
the
content/representation
Co-authored-by: Copilot <[email protected]>
ahouseholder
changed the base branch from
main
to
copilot/refactor-default-exploitation-values
ahouseholder
merged commit 96fd1af
into
copilot/refactor-default-exploitation-values
5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR refactors the "Default Safety Values" tip from
docs/howto/bootstrap/collect.mdinto a reusable includable file, following the same pattern established in PR #1010 for other decision point tips.Changes
Created
docs/_includes/default_safety_values.md- New includable file containing the "Default Safety Values" tip that recommends assuming a marginal Safety Impact when no information is available about the device's environment.Modified
docs/howto/bootstrap/collect.md- Replaced the inline tip with{% include-markdown "../../_includes/default_safety_values.md" %}to reference the new includable file.docs/reference/decision_points/safety_impact.md- Added the include in two strategic locations:Benefits
Related Issues
Closes #[issue number] (child of #522)
Pattern Consistency
This refactoring follows the established pattern for includable tips, consistent with:
_includes/automatable_cvss_ssvc.md_includes/value_density_cvss_ssvc.md_includes/safety_cvss_ssvc.mdOriginal prompt
Fixes #963
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.